From c00234973fbd6a5c3343b3afb1f7ed7c0b02c81d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= <fpeters@entrouvert.com>
Date: Thu, 19 Sep 2019 10:07:17 +0200
Subject: [PATCH] misc: don't crash evaluating roles when
 formdef.workflow_roles is None (#36252)

---
 wcs/forms/backoffice.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/wcs/forms/backoffice.py b/wcs/forms/backoffice.py
index 84c2acdf4..0dc62677a 100644
--- a/wcs/forms/backoffice.py
+++ b/wcs/forms/backoffice.py
@@ -249,7 +249,8 @@ class FormDefUI(object):
                 r += htmltext('<td class="select"><input type="checkbox" name="select[]" ')
                 r += htmltext('value="%s"') % filled.id
                 workflow_roles = {}
-                workflow_roles.update(self.formdef.workflow_roles)
+                if self.formdef.workflow_roles:
+                    workflow_roles.update(self.formdef.workflow_roles)
                 if filled.workflow_roles:
                     workflow_roles.update(filled.workflow_roles)
                 for function_key, function_value in workflow_roles.items():