From 74e8a0630c5a5aae8b61da03fe699471e9393b59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= Date: Tue, 18 May 2021 17:27:15 +0200 Subject: [PATCH] forms: restore checkboxes widget labels (#54098) --- tests/form_pages/test_all.py | 3 ++- wcs/qommon/form.py | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/form_pages/test_all.py b/tests/form_pages/test_all.py index fdb391bba..1cc47c2a3 100644 --- a/tests/form_pages/test_all.py +++ b/tests/form_pages/test_all.py @@ -539,7 +539,7 @@ def test_form_items_submit(pub): formdef.fields = [ fields.ItemsField( id='0', - label='items', + label='List of items', type='items', required=True, varname='foo', @@ -550,6 +550,7 @@ def test_form_items_submit(pub): formdef.data_class().wipe() page = get_app(pub).get('/test/') + assert 'List of items' in page.text next_page = page.forms[0].submit('submit') # but the field is required assert next_page.pyquery('div.error').text() == 'required field' next_page.forms[0]['f0$element0'].checked = True diff --git a/wcs/qommon/form.py b/wcs/qommon/form.py index cf8bc185a..16cd57de6 100644 --- a/wcs/qommon/form.py +++ b/wcs/qommon/form.py @@ -1469,8 +1469,6 @@ class CheckboxesWidget(Widget): self.inline = kwargs.pop('inline', True) self.min_choices = int(kwargs.pop('min_choices', 0) or 0) self.max_choices = int(kwargs.pop('max_choices', 0) or 0) - if 'title' in kwargs: - del kwargs['title'] if 'readonly' in kwargs: del kwargs['readonly'] self.readonly = True