From 71f45fedec7f6e3c14413d88a92ae1fba6f6900e Mon Sep 17 00:00:00 2001 From: Chris Buechler Date: Wed, 12 Nov 2014 11:26:38 -0600 Subject: [PATCH] Don't allow interface descriptions that are strictly numbers as that generates an invalid ruleset. Ticket #4005 --- usr/local/www/interfaces.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/usr/local/www/interfaces.php b/usr/local/www/interfaces.php index 7e923aa18..6aaf99ae7 100644 --- a/usr/local/www/interfaces.php +++ b/usr/local/www/interfaces.php @@ -502,6 +502,9 @@ if ($_POST['apply']) { break; } } + if(is_numeric($_POST['descr'])) { + $input_errors[] = gettext("The interface description cannot contain only numbers."); + } /* input validation */ if (isset($config['dhcpd']) && isset($config['dhcpd'][$if]['enable']) && (! preg_match("/^staticv4/", $_POST['type']))) $input_errors[] = gettext("The DHCP Server is active on this interface and it can be used only with a static IP configuration. Please disable the DHCP Server service on this interface first, then change the interface configuration.");