From e24269f6715c9a44b5b7bbe56a293a8f29eac103 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= Date: Sun, 20 Mar 2022 13:20:22 +0100 Subject: [PATCH] prometheus: do not set empty list as string as name (#62964) --- .../prometheus-system-exporter.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/prometheus-entrouvert-exporter/prometheus-system-exporter.py b/prometheus-entrouvert-exporter/prometheus-system-exporter.py index d465dcb..e2abeb1 100755 --- a/prometheus-entrouvert-exporter/prometheus-system-exporter.py +++ b/prometheus-entrouvert-exporter/prometheus-system-exporter.py @@ -230,8 +230,13 @@ def units(ctn): manager = dbus.Interface(s, "org.freedesktop.systemd1.Manager") units = manager.ListUnits() n = len([u for u in units if u[3] == "failed" and not u[0].startswith("user@")]) - name = [u[0].replace('dbus.String', '') for u in units if u[3] == "failed" and not u[0].startswith("user@")] - eo_units.labels(ctn, name, "failed").set(n) + name = [ + u[0].replace('dbus.String', '') for u in units if u[3] == "failed" and not u[0].startswith("user@") + ] + if name: + eo_units.labels(ctn, name, "failed").set(n) + else: + eo_units.labels(ctn, "failed").set(n) def run_in_machines(ctn):