entrouvert
/
publik-base-theme
15
1
Fork 1
Code Issues Pull Requests 11 Releases Wiki Activity

includes: remove div from evolution metadata selector (#71091) #9

Merged
fpeters merged 1 commits from wip/71091-evolution-metadata-p-tag into main 2022-11-12 17:01:57 +01:00
Conversation 0 Commits 1 Files Changed 17 +23 -25
fpeters commented 2022-11-08 16:52:01 +01:00
Owner
Copy Link

Qui va avec une branche du même nom côté w.c.s., qui remplace <div> par <p>.

Qui va avec une branche du même nom côté w.c.s., qui remplace `<div>` par `<p>`.
fpeters changed title from includes: remove div from evolution metadata selector (#71091) to WIP: includes: remove div from evolution metadata selector (#71091) 2022-11-08 16:52:29 +01:00
fpeters force-pushed wip/71091-evolution-metadata-p-tag from 8f758efaf1 to 48533a1de7 2022-11-08 16:55:37 +01:00 Compare
fpeters changed title from WIP: includes: remove div from evolution metadata selector (#71091) to includes: remove div from evolution metadata selector (#71091) 2022-11-08 16:57:50 +01:00
aberriot approved these changes 2022-11-08 17:13:29 +01:00
aberriot left a comment
Owner
Copy Link

Okay pour moi sous réserve d'une réponse à mes questions :)

Okay pour moi sous réserve d'une réponse à mes questions :)
static/includes/wcs/_bulk.scss Outdated
@ -270,3 +270,3 @@
display: inline-block;
background: $form-background;
margin-left: 60px;
margin: 0 0 0 60px;
aberriot commented 2022-11-08 17:12:35 +01:00
Owner
Copy Link

On a un changement de marges ici qui me semble déborder du scope du ticket mais je rate peut-être quelque chose ?

On a un changement de marges ici qui me semble déborder du scope du ticket mais je rate peut-être quelque chose ?
fpeters commented 2022-11-08 17:22:50 +01:00
Author
Owner
Copy Link

On était sur un <div> donc marges à 0, donc ici il faut se "protéger" des marges haut/bas des paragraphes.

On était sur un `<div>` donc marges à 0, donc ici il faut se "protéger" des marges haut/bas des paragraphes.
aberriot commented 2022-11-08 17:28:18 +01:00
Owner
Copy Link

Okay, ça fait sens, let's go

Okay, ça fait sens, let's go
aberriot marked this conversation as resolved
static/strasbourg-2018/_custom.scss Outdated
@ -237,3 +237,3 @@
display: inline-block;
background: white;
margin-left: 60px;
margin: 0 0 0 60px;
aberriot commented 2022-11-08 17:12:56 +01:00
Owner
Copy Link

Idem ici

Idem ici
fpeters marked this conversation as resolved
fpeters force-pushed wip/71091-evolution-metadata-p-tag from 48533a1de7 to 0a5898c57a 2022-11-12 17:01:11 +01:00 Compare
fpeters merged commit 0a5898c57a into main 2022-11-12 17:01:57 +01:00
fpeters deleted branch wip/71091-evolution-metadata-p-tag 2022-11-12 17:01:57 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
aberriot
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/publik-base-theme#9
No description provided.
Delete Branch "wip/71091-evolution-metadata-p-tag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?