variants: add cell--title class to cell titles (#74052) #151

Merged
csechet merged 1 commits from wip/74052-Variants-ajouter-la-class-cell-t into main 3 weeks ago
Owner
There is no content yet.
csechet added 1 commit 4 months ago
gitea-wip/publik-base-theme/pipeline/pr-main This commit looks good Details
3996eae678
variants: add cell--title class to cell titles (#74052)
Poster
Owner

Je n'ai pas modifié templates/variants/saint-chamond/combo/wcs/forms_of_category.html:12:7

Où .cell--title et h2:first-child ne sont pas équivalents dans le cas où on a une image, et ça semble stylé spécialement par #content .wcsformsofcategorycell picture + h2 dans le _custom.scss.

Je n'ai pas modifié templates/variants/saint-chamond/combo/wcs/forms_of_category.html:12:7 Où .cell--title et h2:first-child ne sont pas équivalents dans le cas où on a une image, et ça semble stylé spécialement par #content .wcsformsofcategorycell picture + h2 dans le _custom.scss.
tjund requested changes 4 months ago
@ -12,3 +12,3 @@
<div class="tile-head">
<div class="tile-title">
<h2>{{commerce.properties.nom}}<br><span class="subtitle">{{commerce.properties.categorie}}</span></h2>
<h2 class="cell-title">{{commerce.properties.nom}}<br><span class="subtitle">{{commerce.properties.categorie}}</span></h2>
tjund commented 4 months ago
Owner

Manque un tirer

Manque un tirer
csechet force-pushed wip/74052-Variants-ajouter-la-class-cell-t from 3996eae678 to a430759ff4 4 months ago
tjund requested review from tjund 2 months ago
tjund approved these changes 3 weeks ago
tjund left a comment
Owner

Aller, on passe ça, à priori aucun impact et ça va dans le bon sens.

Aller, on passe ça, à priori aucun impact et ça va dans le bon sens.
csechet merged commit 1ffc0b7105 into main 3 weeks ago
csechet deleted branch wip/74052-Variants-ajouter-la-class-cell-t 3 weeks ago

Reviewers

tjund approved these changes 3 weeks ago
gitea-wip/publik-base-theme/pipeline/pr-main This commit looks good
gitea/publik-base-theme/pipeline/pr-main This commit looks good
gitea/publik-base-theme/pipeline/head This commit looks good
The pull request has been merged as 1ffc0b7105.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b wip/74052-Variants-ajouter-la-class-cell-t main
git pull origin wip/74052-Variants-ajouter-la-class-cell-t

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff wip/74052-Variants-ajouter-la-class-cell-t
git push origin main
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/publik-base-theme#151
Loading…
There is no content yet.