entrouvert
/
passerelle
15
0
Fork 0
Code Issues Pull Requests 15 Releases Activity

toulouse-maelis: add a type filter on personal catalog (#74396) #100

Merged
nroche merged 1 commits from wip/74396-parsifal-person-catalog-type-filter into main 2023-02-24 09:10:42 +01:00
Conversation 1 Commits 1 Files Changed 2 +44 -2
nroche commented 2023-02-09 23:20:52 +01:00
Owner
Copy Link

Ajouter un filtre sur le catalogue personnalisé.

Ajouter un filtre sur le catalogue personnalisé.
nroche force-pushed wip/74396-parsifal-person-catalog-type-filter from bbf8d00a9c to 3076c4e74b 2023-02-12 21:16:56 +01:00 Compare
nroche force-pushed wip/74396-parsifal-person-catalog-type-filter from 3076c4e74b to 71c277d64f 2023-02-19 14:11:46 +01:00 Compare
nroche force-pushed wip/74396-parsifal-person-catalog-type-filter from 71c277d64f to 2cb4f1affa 2023-02-22 15:05:07 +01:00 Compare
ecazenave requested changes 2023-02-22 17:46:23 +01:00
ecazenave left a comment
Owner
Copy Link

Une remarque mineure.

Une remarque mineure.
passerelle/contrib/toulouse_maelis/models.py Outdated
@ -548,2 +555,4 @@
'Activity', 'getPersonCatalogueActivity', getPersonCatalogueActivityRequestBean=params
)
if type_ids:
codes = [x.strip() for x in type_ids.split(',') if x.strip()]
ecazenave commented 2023-02-22 17:44:43 +01:00
Owner
Copy Link

A quoi sert le if x.strip() ?

Plutôt if x ?

A quoi sert le if x.strip() ? Plutôt if x ?
nroche commented 2023-02-22 19:50:28 +01:00
Author
Owner
Copy Link

A quoi sert le if x.strip() ?

J'imagine à ne pas ajouter de chaîne vide si on laisse traîner une virgule suivie d'un espace, genre

[x.strip() for x in 'a, '.split(',') if x]
['a', '']

Mais en vrai, j'avoue que j'ai copié sur une camarade.
eac46f952d/passerelle/apps/base_adresse/models.py (L448)

> A quoi sert le if x.strip() ? J'imagine à ne pas ajouter de chaîne vide si on laisse traîner une virgule suivie d'un espace, genre ``` [x.strip() for x in 'a, '.split(',') if x] ['a', ''] ``` Mais en vrai, j'avoue que j'ai copié sur une camarade. https://git.entrouvert.org/entrouvert/passerelle/src/commit/eac46f952d7582eb38ed9f9ef4eea62ff2dffa32/passerelle/apps/base_adresse/models.py#L448
ecazenave approved these changes 2023-02-23 10:51:54 +01:00
nroche force-pushed wip/74396-parsifal-person-catalog-type-filter from 2cb4f1affa to 50ca42ec1d 2023-02-24 08:49:03 +01:00 Compare
nroche merged commit 50ca42ec1d into main 2023-02-24 09:10:42 +01:00
bdauvergne deleted branch wip/74396-parsifal-person-catalog-type-filter 2023-02-27 10:22:32 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
ecazenave
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/passerelle#100
No description provided.
Delete Branch "wip/74396-parsifal-person-catalog-type-filter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?