From f9b7e42e144e0ad08f4083ef61c266f3c1d5b784 Mon Sep 17 00:00:00 2001 From: Emmanuel Cazenave Date: Mon, 20 Mar 2023 17:36:56 +0100 Subject: [PATCH] api_entreprise: use v3 in exercices endpoint (#75621) --- passerelle/apps/api_entreprise/models.py | 2 +- tests/test_api_entreprise.py | 37 +++++++++--------------- 2 files changed, 14 insertions(+), 25 deletions(-) diff --git a/passerelle/apps/api_entreprise/models.py b/passerelle/apps/api_entreprise/models.py index 8a3f44ea..79f46e73 100644 --- a/passerelle/apps/api_entreprise/models.py +++ b/passerelle/apps/api_entreprise/models.py @@ -432,7 +432,7 @@ class APIEntreprise(BaseResource): }, ) def exercices(self, request, siret, **kwargs): - return self.get('v2/exercices/%s/' % siret, **kwargs) + return self.get('v3/dgfip/etablissements/%s/chiffres_affaires' % siret, raw=True, **kwargs) @endpoint( perm='can_access', diff --git a/tests/test_api_entreprise.py b/tests/test_api_entreprise.py index b6e33600..e09a4714 100644 --- a/tests/test_api_entreprise.py +++ b/tests/test_api_entreprise.py @@ -313,23 +313,11 @@ ETABLISSEMENT_EFFECTIFS_MENSUELS_ACOSS_COVID = { EXERCICES_RESPONSE = { - "exercices": [ - { - "ca": "648374448", - "date_fin_exercice": "2016-12-31T00:00:00+01:00", - "date_fin_exercice_timestamp": 1483138800, - }, - { - "ca": "491463386", - "date_fin_exercice": "2015-12-31T00:00:00+01:00", - "date_fin_exercice_timestamp": 1451516400, - }, - { - "ca": "473899061", - "date_fin_exercice": "2014-12-31T00:00:00+01:00", - "date_fin_exercice_timestamp": 1419980400, - }, - ] + "data": [ + {"data": {"chiffre_affaires": 900001, "date_fin_exercice": "2015-12-01"}, "links": {}, "meta": {}} + ], + "meta": {}, + "links": {}, } @@ -743,15 +731,16 @@ def test_etablissment_effectifs_mensuels_acoss_covid(app, resource): def test_exercices(app, resource): with responses.RequestsMock() as rsps: - rsps.get('https://entreprise.api.gouv.fr/v2/exercices/418166096/', json=EXERCICES_RESPONSE) + rsps.get( + 'https://entreprise.api.gouv.fr/v3/dgfip/etablissements/418166096/chiffres_affaires', + json=EXERCICES_RESPONSE, + ) response = app.get('/api-entreprise/test/exercices/418166096/', params=REQUEST_PARAMS) data = response.json['data'] - assert len(data['exercices']) == 3 - exercice = data['exercices'][0] - assert exercice['ca'] == '648374448' - assert exercice['date_fin_exercice'] == '2016-12-31T00:00:00+01:00' - assert exercice['date_fin_exercice_timestamp'] == 1483138800 - assert exercice['date_fin_exercice_datetime'] == '2016-12-30T23:00:00Z' + assert len(data) == 1 + exercice = data[0]['data'] + assert exercice['chiffre_affaires'] == 900001 + assert exercice['date_fin_exercice'] == '2015-12-01' def test_error_500(app, resource):