From efb19190043d048af0cc2b542a3e2bad2ed7b18b Mon Sep 17 00:00:00 2001
From: Serghei Mihai <smihai@entrouvert.com>
Date: Tue, 27 Oct 2020 09:48:51 +0100
Subject: [PATCH] grenoble_gru: do not send empty dem_pav if empty (#48046)

---
 passerelle/contrib/grenoble_gru/models.py |  2 +-
 tests/test_grenoble_gru.py                | 12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/passerelle/contrib/grenoble_gru/models.py b/passerelle/contrib/grenoble_gru/models.py
index 434e2ee0..9bf23dbe 100644
--- a/passerelle/contrib/grenoble_gru/models.py
+++ b/passerelle/contrib/grenoble_gru/models.py
@@ -133,7 +133,7 @@ class GrenobleGRU(BaseResource):
         if 'applicant_free_address' in data:
             payload['dem_adresse_manuelle'] = data['applicant_free_address']
 
-        if 'dem_pav' in data:
+        if 'dem_pav' in data and data['dem_pav']:
             payload['dem_pav'] = data['dem_pav']
 
         return payload
diff --git a/tests/test_grenoble_gru.py b/tests/test_grenoble_gru.py
index 31d8a919..cee0cd58 100644
--- a/tests/test_grenoble_gru.py
+++ b/tests/test_grenoble_gru.py
@@ -269,6 +269,18 @@ def test_demand_creation_params(app, setup):
         assert request_post.call_args[1]['data']['obs_demande_urgente'] == 1
         assert request_post.call_args[1]['data']['dem_reponse'] == 1
 
+        # make sure empty dem_pav value is not sent
+        payload['dem_pav'] = ''
+        app.post_json(
+            reverse('generic-endpoint',
+                    kwargs={
+                        'connector': 'grenoble-gru',
+                        'slug': setup.slug,
+                        'endpoint': 'create-demand'
+                    }),
+            params=payload)
+        assert 'dem_pav' not in request_post.call_args[1]['data']
+
 
 def test_add_attachment_to_demand(app, setup):
     with mock.patch('passerelle.utils.Request.post') as request_post: