From ac4842c64dd87fc4e832b26e10c75b773691e0ad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= <fpeters@entrouvert.com>
Date: Thu, 6 Apr 2023 08:26:15 +0200
Subject: [PATCH] gdema: really do not log requests (#76309)

---
 passerelle/contrib/gdema/models.py |  4 ++--
 tests/test_gdema.py                | 10 ++++++++++
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/passerelle/contrib/gdema/models.py b/passerelle/contrib/gdema/models.py
index 4dd7da51..cceee464 100644
--- a/passerelle/contrib/gdema/models.py
+++ b/passerelle/contrib/gdema/models.py
@@ -165,10 +165,10 @@ class Gdema(BaseResource):
         headers = {}
         headers['Accept'] = 'application/json'
         if payload is None:
-            self.log_requests_errors = False
+            self.requests.log_requests_errors = False
             result = self.requests.get(url, auth=auth, headers=headers)
         else:
-            self.log_requests_errors = True
+            self.requests.log_requests_errors = True
             headers['Content-Type'] = 'application/json'
             data = json.dumps(payload)
             result = self.requests.post(url, data=data, auth=auth, headers=headers)
diff --git a/tests/test_gdema.py b/tests/test_gdema.py
index 7e6acea5..99c031da 100644
--- a/tests/test_gdema.py
+++ b/tests/test_gdema.py
@@ -2,6 +2,7 @@ import json
 from unittest import mock
 
 import pytest
+import responses
 from django.contrib.contenttypes.models import ContentType
 
 import tests.utils
@@ -181,6 +182,15 @@ def test_gdema_get_request(app, gdema):
         assert resp.json['data'] == {'Id': '1', 'State': '64', 'StateLabel': 'Cloturée'}
 
 
+@responses.activate
+def test_gdema_get_request_error(app, gdema, caplog):
+    endpoint = tests.utils.generic_endpoint_url('gdema', 'get-request', slug=gdema.slug)
+    responses.add(responses.GET, 'https://gdema.example.net/api/request/1', body=b'xxx', status=404)
+    resp = app.get(endpoint + '/1/', status=200)
+    assert resp.json['err'] == 1
+    assert [x for x in caplog.records if '=> 404' in x.message][0].levelname == 'INFO'
+
+
 def test_gdema_create_request(app, gdema):
     endpoint = tests.utils.generic_endpoint_url('gdema', 'create-request', slug=gdema.slug)
     assert endpoint == '/gdema/test/create-request'