From 7089380db2bdcb35e9a09341d6d33c3c6f7ad4dc Mon Sep 17 00:00:00 2001
From: Serghei MIHAI <smihai@entrouvert.com>
Date: Mon, 2 Nov 2015 07:45:25 +0100
Subject: [PATCH] set the correct href for external urls (#8823)

---
 www/index.html  | 10 ++++------
 www/js/index.js |  9 ---------
 2 files changed, 4 insertions(+), 15 deletions(-)

diff --git a/www/index.html b/www/index.html
index 6c8ea7a..08b8b44 100644
--- a/www/index.html
+++ b/www/index.html
@@ -67,9 +67,7 @@
         <script type="text/x-tmpl" id="momo-default-footer-tmpl">
           <div class="col-xs-6 navbar-btn text-left">
               <a href="https://dev.entrouvert.org/projects/momo/"
-                  class="btn btn-success pull-left momo-repo"
-                  target="_system"
-                  onclick="javascript:app.utils.onExternalLinkClick()">Momo repository</a>
+                  class="btn btn-success pull-left momo-repo" target="_system">Momo repository</a>
           </div>
           <div class="col-xs-6 navbar-btn text-right">
               <a href="mailto:{%= o.meta.contact %}"
@@ -178,7 +176,7 @@
         </script>
 
         <script type="text/x-tmpl" id="momo-list-item-tmpl">
-            <a href="#{%= o.id %}" class="{% if(!o.header){ %} list-group-item {% } %} clearfix {%= o.external ? 'offline-disable' : '' %}">
+          <a href="{% if(!o.external) { %}#{%= o.id %}{% } else { %}{%= o.url %}{% } %}" class="{% if(!o.header){ %} list-group-item {% } %} clearfix" target="_system">
                 {% if(o.header){ %}
                     <span class="pull-left">
                         {% if(o.icon){ %}
@@ -224,8 +222,8 @@
         </script>
 
         <script type="text/x-tmpl" id="momo-icon-item-tmpl">
-            <div class="col-xs-{%= o.colxs %} col-sm-{%= o.colsm %} col-md-{%= o.colmd %} col-lg-{%= o.collg %}">
-                <a href="#{%= o.id %}" class="btn btn-block text-center {%= o.className || 'btn-default' %} {%= o.external ? 'offline-disable' : '' %}">
+          <div class="col-xs-{%= o.colxs %} col-sm-{%= o.colsm %} col-md-{%= o.colmd %} col-lg-{%= o.collg %}">
+            <a href="{% if(!o.external) { %}#{%= o.id %}{% } else { %}{%= o.url %}{% } %}" class="btn btn-block text-center {%= o.className || 'btn-default' %}" target="_system">
                     {% if(o.external){ %}
                         <i class="fa fa-external-link top-right"></i>
                     {% } %}
diff --git a/www/js/index.js b/www/js/index.js
index 535fb53..7c54c3c 100644
--- a/www/js/index.js
+++ b/www/js/index.js
@@ -1445,15 +1445,6 @@ var app = {
             }
         },
 
-        onExternalLinkClick: function(e){
-            e = e || window.event;
-            var targ = e.target || e.srcElement;
-            if (targ.nodeType === 3){ targ = targ.parentNode; }
-            var url = targ.getAttribute("href");
-            app.utils.openExternalURL(url);
-            return false;
-        },
-
         openExternalURL: function(url){
             window.replaceHash(app.parentPage);
             if(navigator.app){ // Android