From aa854141b9943b9da8e383a76680480a94e7b69b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Corentin=20S=C3=A9chet?= Date: Mon, 11 Apr 2022 15:01:25 +0200 Subject: [PATCH] sources: catch timeout error on page load --- frontools/sources.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontools/sources.py b/frontools/sources.py index 5d2df72..9034ba7 100644 --- a/frontools/sources.py +++ b/frontools/sources.py @@ -30,9 +30,9 @@ class Browser: async def load_page(self, url: str) -> AsyncGenerator[Page, None]: page = await self._browser_context.new_page() await page.route("*", self._source.route) - await page.goto(url) for retry in range(0, 3): try: + await page.goto(url) await page.wait_for_load_state("networkidle") break except TimeoutError: @@ -60,7 +60,7 @@ class Source(ABC): ) -> AsyncGenerator[Browser, None]: """Return a Playwright browser that will eventually get files from local cache""" - viewport: Optional[ViewportSize] = cast( + viewport: ViewportSize = cast( ViewportSize, None ) # Playwright typings are broken