From a041a2ef8165d109bad8e03dc15a97b205f1edf5 Mon Sep 17 00:00:00 2001 From: Benjamin Dauvergne Date: Fri, 30 Apr 2010 09:23:01 +0000 Subject: [PATCH] Initialize all uninitialized rc variables --- lasso/id-ff/login.c | 4 ++-- lasso/id-ff/logout.c | 4 ++-- lasso/id-ff/name_identifier_mapping.c | 2 +- lasso/id-ff/name_registration.c | 2 +- lasso/id-wsf-2.0/discovery.c | 2 +- lasso/id-wsf-2.0/saml2_login.c | 2 +- lasso/id-wsf/authentication.c | 2 +- lasso/id-wsf/discovery.c | 2 +- lasso/saml-2.0/assertion_query.c | 6 +++--- lasso/saml-2.0/login.c | 4 ++-- lasso/saml-2.0/profile.c | 4 ++-- lasso/xml/dst_modify.c | 2 +- lasso/xml/dst_modify_response.c | 2 +- lasso/xml/dst_query.c | 2 +- lasso/xml/dst_query_response.c | 2 +- lasso/xml/misc_text_node.c | 2 +- lasso/xml/tools.c | 2 +- lasso/xml/ws/wsse_username_token.c | 2 +- lasso/xml/xml.c | 4 ++-- tests/login_tests.c | 4 ++-- tests/login_tests_saml2.c | 4 ++-- tests/perfs.c | 2 +- tests/tests.c | 2 +- 23 files changed, 32 insertions(+), 32 deletions(-) diff --git a/lasso/id-ff/login.c b/lasso/id-ff/login.c index 902f6f16..f36062f6 100644 --- a/lasso/id-ff/login.c +++ b/lasso/id-ff/login.c @@ -1725,7 +1725,7 @@ gint lasso_login_init_idp_initiated_authn_request(LassoLogin *login, const gchar *remote_providerID) { - int rc; + int rc = 0; LassoProfile *profile; profile = LASSO_PROFILE(login); @@ -2253,7 +2253,7 @@ init_from_xml(LassoNode *node, xmlNode *xmlnode) { LassoLogin *login = LASSO_LOGIN(node); xmlNode *t; - int rc; + int rc = 0; rc = parent_class->init_from_xml(node, xmlnode); if (rc) return rc; diff --git a/lasso/id-ff/logout.c b/lasso/id-ff/logout.c index 2ccffe88..9e954255 100644 --- a/lasso/id-ff/logout.c +++ b/lasso/id-ff/logout.c @@ -811,7 +811,7 @@ lasso_logout_process_response_msg(LassoLogout *logout, gchar *response_msg) LassoHttpMethod response_method; LassoMessageFormat format; LassoLibStatusResponse *response; - int rc; + int rc = 0; g_return_val_if_fail(LASSO_IS_LOGOUT(logout), LASSO_PARAM_ERROR_BAD_TYPE_OR_NULL_OBJ); g_return_val_if_fail(response_msg != NULL, LASSO_PARAM_ERROR_INVALID_VALUE); @@ -1260,7 +1260,7 @@ get_xmlNode(LassoNode *node, gboolean lasso_dump) static int init_from_xml(LassoNode *node, xmlNode *xmlnode) { - int rc; + int rc = 0; rc = parent_class->init_from_xml(node, xmlnode); if (rc == 0) { diff --git a/lasso/id-ff/name_identifier_mapping.c b/lasso/id-ff/name_identifier_mapping.c index f074fb01..a91b6d71 100644 --- a/lasso/id-ff/name_identifier_mapping.c +++ b/lasso/id-ff/name_identifier_mapping.c @@ -353,7 +353,7 @@ lasso_name_identifier_mapping_process_response_msg(LassoNameIdentifierMapping *m LassoProvider *remote_provider; LassoMessageFormat format; LassoLibNameIdentifierMappingResponse *response; - int rc; + int rc = 0; char *statusCodeValue; g_return_val_if_fail(LASSO_IS_NAME_IDENTIFIER_MAPPING(mapping), diff --git a/lasso/id-ff/name_registration.c b/lasso/id-ff/name_registration.c index bd052bfd..59d59d80 100644 --- a/lasso/id-ff/name_registration.c +++ b/lasso/id-ff/name_registration.c @@ -453,7 +453,7 @@ lasso_name_registration_process_response_msg(LassoNameRegistration *name_registr LassoHttpMethod response_method; LassoLibStatusResponse *response; LassoMessageFormat format; - int rc; + int rc = 0; char *statusCodeValue; g_return_val_if_fail(LASSO_IS_NAME_REGISTRATION(name_registration), diff --git a/lasso/id-wsf-2.0/discovery.c b/lasso/id-wsf-2.0/discovery.c index ed6b7f84..6ad08aa7 100644 --- a/lasso/id-wsf-2.0/discovery.c +++ b/lasso/id-wsf-2.0/discovery.c @@ -209,7 +209,7 @@ lasso_idwsf2_discovery_status2rc(LassoIdWsf2UtilStatus *status) size_t i = 0; static struct { const char *code; - int rc; + int rc = 0; } code2rc[] = { { LASSO_IDWSF2_DISCOVERY_STATUS_CODE_OK, 0}, { LASSO_IDWSF2_DISCOVERY_STATUS_CODE_FAILED, LASSO_IDWSF2_DISCOVERY_ERROR_FAILED }, diff --git a/lasso/id-wsf-2.0/saml2_login.c b/lasso/id-wsf-2.0/saml2_login.c index dafe58a3..eda6adaf 100644 --- a/lasso/id-wsf-2.0/saml2_login.c +++ b/lasso/id-wsf-2.0/saml2_login.c @@ -70,7 +70,7 @@ lasso_server_create_assertion_as_idwsf2_security_token(LassoServer *server, LassoProvider *audience) { LassoSaml2Assertion *assertion; - int rc; + int rc = 0; if (! LASSO_IS_SERVER(server)) return NULL; diff --git a/lasso/id-wsf/authentication.c b/lasso/id-wsf/authentication.c index 4707b04d..0dee1e29 100644 --- a/lasso/id-wsf/authentication.c +++ b/lasso/id-wsf/authentication.c @@ -665,7 +665,7 @@ get_xmlNode(LassoNode *node, gboolean lasso_dump) static int init_from_xml(LassoNode *node, xmlNode *xmlnode) { - int rc; + int rc = 0; rc = parent_class->init_from_xml(node, xmlnode); if (rc) return rc; diff --git a/lasso/id-wsf/discovery.c b/lasso/id-wsf/discovery.c index c5c7df28..7f5102e6 100644 --- a/lasso/id-wsf/discovery.c +++ b/lasso/id-wsf/discovery.c @@ -454,7 +454,7 @@ lasso_discovery_process_modify_response_msg(LassoDiscovery *discovery, const gch { LassoWsfProfile *profile = NULL; LassoDiscoModifyResponse *response = NULL; - int rc; + int rc = 0; g_return_val_if_fail(LASSO_IS_DISCOVERY(discovery), LASSO_PARAM_ERROR_BAD_TYPE_OR_NULL_OBJ); g_return_val_if_fail(message != NULL, LASSO_PARAM_ERROR_INVALID_VALUE); diff --git a/lasso/saml-2.0/assertion_query.c b/lasso/saml-2.0/assertion_query.c index f549940d..09a8245c 100644 --- a/lasso/saml-2.0/assertion_query.c +++ b/lasso/saml-2.0/assertion_query.c @@ -304,7 +304,7 @@ lasso_assertion_query_validate_request(LassoAssertionQuery *assertion_query) LassoProfile *profile; LassoProvider *remote_provider; LassoSamlp2StatusResponse *response; - int rc; + int rc = 0; g_return_val_if_fail(LASSO_IS_ASSERTION_QUERY(assertion_query), LASSO_PARAM_ERROR_INVALID_VALUE); @@ -335,7 +335,7 @@ lasso_assertion_query_build_response_msg(LassoAssertionQuery *assertion_query) { LassoProfile *profile; LassoSamlp2StatusResponse *response; - int rc; + int rc = 0; g_return_val_if_fail(LASSO_IS_ASSERTION_QUERY(assertion_query), LASSO_PARAM_ERROR_INVALID_VALUE); @@ -380,7 +380,7 @@ lasso_assertion_query_process_response_msg( { LassoProfile *profile; LassoSamlp2StatusResponse *response; - int rc; + int rc = 0; lasso_bad_param(ASSERTION_QUERY, assertion_query); profile = &assertion_query->parent; diff --git a/lasso/saml-2.0/login.c b/lasso/saml-2.0/login.c index 0d62a427..2d5bc181 100644 --- a/lasso/saml-2.0/login.c +++ b/lasso/saml-2.0/login.c @@ -954,7 +954,7 @@ gint lasso_saml20_login_process_request_msg(LassoLogin *login, gchar *request_msg) { LassoProfile *profile = LASSO_PROFILE(login); - int rc; + int rc = 0; rc = lasso_saml20_profile_process_artifact_resolve(profile, request_msg); if (rc != 0) { @@ -1082,7 +1082,7 @@ gint lasso_saml20_login_process_response_msg(LassoLogin *login, gchar *response_msg) { LassoProfile *profile = LASSO_PROFILE(login); - int rc; + int rc = 0; rc = lasso_saml20_profile_process_artifact_response(profile, response_msg); if (rc) { diff --git a/lasso/saml-2.0/profile.c b/lasso/saml-2.0/profile.c index caac621a..e6e2c9d1 100644 --- a/lasso/saml-2.0/profile.c +++ b/lasso/saml-2.0/profile.c @@ -338,7 +338,7 @@ int lasso_saml20_profile_process_artifact_resolve(LassoProfile *profile, const char *msg) { LassoProvider *remote_provider; - int rc; + int rc = 0; /* FIXME: parse only one time the message, reuse the parsed document for signature * validation */ @@ -474,7 +474,7 @@ lasso_saml20_profile_set_session_from_dump_decrypt( assertion->Subject->EncryptedID->original_data); lasso_release_gobject(assertion->Subject->EncryptedID); } else { /* decrypt */ - int rc; + int rc = 0; rc = lasso_saml2_encrypted_element_decrypt(assertion->Subject->EncryptedID, lasso_server_get_encryption_private_key(profile->server), (LassoNode**) &assertion->Subject->NameID); diff --git a/lasso/xml/dst_modify.c b/lasso/xml/dst_modify.c index 3c30277b..7e8c64ff 100644 --- a/lasso/xml/dst_modify.c +++ b/lasso/xml/dst_modify.c @@ -112,7 +112,7 @@ static int init_from_xml(LassoNode *node, xmlNode *xmlnode) { LassoDstModify *modify = LASSO_DST_MODIFY(node); - int rc; + int rc = 0; rc = parent_class->init_from_xml(node, xmlnode); if (rc) { diff --git a/lasso/xml/dst_modify_response.c b/lasso/xml/dst_modify_response.c index 3b2b5822..d0af68bc 100644 --- a/lasso/xml/dst_modify_response.c +++ b/lasso/xml/dst_modify_response.c @@ -91,7 +91,7 @@ get_xmlNode(LassoNode *node, gboolean lasso_dump) static int init_from_xml(LassoNode *node, xmlNode *xmlnode) { - int rc; + int rc = 0; LassoDstModifyResponse *response = LASSO_DST_MODIFY_RESPONSE(node); rc = parent_class->init_from_xml(node, xmlnode); diff --git a/lasso/xml/dst_query.c b/lasso/xml/dst_query.c index 22dbb66f..3a7c0724 100644 --- a/lasso/xml/dst_query.c +++ b/lasso/xml/dst_query.c @@ -103,7 +103,7 @@ static int init_from_xml(LassoNode *node, xmlNode *xmlnode) { LassoDstQuery *query = LASSO_DST_QUERY(node); - int rc; + int rc = 0; rc = parent_class->init_from_xml(node, xmlnode); if (rc) { diff --git a/lasso/xml/dst_query_response.c b/lasso/xml/dst_query_response.c index 1282e971..f1ac4b5c 100644 --- a/lasso/xml/dst_query_response.c +++ b/lasso/xml/dst_query_response.c @@ -106,7 +106,7 @@ get_xmlNode(LassoNode *node, gboolean lasso_dump) static int init_from_xml(LassoNode *node, xmlNode *xmlnode) { - int rc; + int rc = 0; LassoDstQueryResponse *response = LASSO_DST_QUERY_RESPONSE(node); rc = parent_class->init_from_xml(node, xmlnode); diff --git a/lasso/xml/misc_text_node.c b/lasso/xml/misc_text_node.c index eb9ab864..1450cb71 100644 --- a/lasso/xml/misc_text_node.c +++ b/lasso/xml/misc_text_node.c @@ -89,7 +89,7 @@ static int init_from_xml(LassoNode *node, xmlNode *xmlnode) { LassoMiscTextNode *n = LASSO_MISC_TEXT_NODE(node); - int rc; + int rc = 0; if (xmlnode->type == XML_TEXT_NODE) { n->text_child = TRUE; diff --git a/lasso/xml/tools.c b/lasso/xml/tools.c index d311cf15..a639d8b6 100644 --- a/lasso/xml/tools.c +++ b/lasso/xml/tools.c @@ -1030,7 +1030,7 @@ lasso_node_build_deflated_query(LassoNode *node) xmlChar *ret, *b64_ret; char *rret; unsigned long in_len; - int rc; + int rc = 0; z_stream stream; xmlnode = lasso_node_get_xmlNode(node, FALSE); diff --git a/lasso/xml/ws/wsse_username_token.c b/lasso/xml/ws/wsse_username_token.c index bd407174..3f8c81bb 100644 --- a/lasso/xml/ws/wsse_username_token.c +++ b/lasso/xml/ws/wsse_username_token.c @@ -90,7 +90,7 @@ static struct XmlSnippet schema_snippets[] = { static int init_from_xml(LassoNode *node, xmlNode *xmlnode) { - int rc; + int rc = 0; xmlNode *password; xmlChar *kind; LassoWsseUsernameTokenPrivate *private = LASSO_WSSE_USERNAME_TOKEN_GET_PRIVATE(node); diff --git a/lasso/xml/xml.c b/lasso/xml/xml.c index 851a4336..9d3179d7 100644 --- a/lasso/xml/xml.c +++ b/lasso/xml/xml.c @@ -1911,7 +1911,7 @@ lasso_node_new_from_xmlNode_with_type(xmlNode *xmlnode, char *typename) { GType gtype; LassoNode *node; - int rc; + int rc = 0; if (typename == NULL) return lasso_node_new_from_xmlNode(xmlnode); /* will auto-detect */ @@ -1981,7 +1981,7 @@ lasso_node_init_from_message_with_format(LassoNode *node, const char *message, L /* BASE64 case */ if (any || constraint == LASSO_MESSAGE_FORMAT_BASE64) { if (message[0] != 0 && is_base64(message)) { - int rc; + int rc = 0; msg = g_malloc(strlen(message)); rc = xmlSecBase64Decode((xmlChar*)message, (xmlChar*)msg, strlen(message)); diff --git a/tests/login_tests.c b/tests/login_tests.c index 479b387a..54a2d554 100644 --- a/tests/login_tests.c +++ b/tests/login_tests.c @@ -139,7 +139,7 @@ START_TEST(test02_serviceProviderLogin) LassoServer *spContext, *idpContext; LassoLogin *spLoginContext, *idpLoginContext; LassoLibAuthnRequest *request; - int rc; + int rc = 0; char *relayState; char *authnRequestUrl, *authnRequestQuery; char *responseUrl, *responseQuery; @@ -315,7 +315,7 @@ START_TEST(test03_serviceProviderLogin) LassoServer *spContext, *idpContext; LassoLogin *spLoginContext, *idpLoginContext; LassoLibAuthnRequest *request; - int rc; + int rc = 0; char *relayState; char *authnRequestUrl, *authnRequestQuery; char *responseUrl, *responseQuery; diff --git a/tests/login_tests_saml2.c b/tests/login_tests_saml2.c index 2f6d59a2..78913add 100644 --- a/tests/login_tests_saml2.c +++ b/tests/login_tests_saml2.c @@ -141,7 +141,7 @@ START_TEST(test02_saml2_serviceProviderLogin) LassoLogin *spLoginContext = NULL, *idpLoginContext = NULL; LassoLogout *spLogoutContext = NULL, *idpLogoutContext = NULL; LassoSamlp2AuthnRequest *request = NULL; - int rc; + int rc = 0; char *relayState = NULL; char *authnRequestUrl = NULL, *authnRequestQuery = NULL; char *logoutRequestUrl = NULL, *logoutRequestQuery = NULL; @@ -352,7 +352,7 @@ START_TEST(test03_saml2_serviceProviderLogin) char *spIdentityContextDump = NULL; char *spSessionDump = NULL; char *idpLoginDump = NULL; - int rc; + int rc = 0; serviceProviderContextDump = generateServiceProviderContextDump(); spContext = lasso_server_new_from_dump(serviceProviderContextDump); diff --git a/tests/perfs.c b/tests/perfs.c index 79bd580f..6f60275b 100644 --- a/tests/perfs.c +++ b/tests/perfs.c @@ -34,7 +34,7 @@ create_authn_response_msg(char *query) LassoServer *server; LassoLogin *login; char *t; - int rc; + int rc = 0; server = lasso_server_new( TESTSDATADIR "/idp1-la/metadata.xml", diff --git a/tests/tests.c b/tests/tests.c index 5217bbb8..3b0267f1 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -57,7 +57,7 @@ SuiteFunction suites[] = { int main(int argc, char *argv[]) { - int rc; + int rc = 0; SRunner *sr; int i; int dont_fork = 0;