From 1b23ff37acf20c3f36b7051e91d243813974c827 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= <fpeters@entrouvert.com>
Date: Fri, 17 Jun 2022 20:04:12 +0200
Subject: [PATCH] ci: run pre-commit & pylint

---
 Jenkinsfile |  13 ++++++
 pylint.rc   | 115 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 pylint.sh   |   5 +++
 tox.ini     |  12 ++++++
 4 files changed, 145 insertions(+)
 create mode 100644 pylint.rc
 create mode 100755 pylint.sh
 create mode 100644 tox.ini

diff --git a/Jenkinsfile b/Jenkinsfile
index 0245fae..f6964da 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -4,6 +4,19 @@ pipeline {
     agent any
     options { disableConcurrentBuilds() }
     stages {
+        stage('Unit Tests') {
+            steps {
+                sh 'tox -rv'
+            }
+            post {
+                always {
+                    script {
+                        utils = new Utils()
+                        utils.publish_pylint('pylint.out')
+                    }
+                }
+            }
+        }
         stage('Packaging') {
             steps {
                 script {
diff --git a/pylint.rc b/pylint.rc
new file mode 100644
index 0000000..935d60c
--- /dev/null
+++ b/pylint.rc
@@ -0,0 +1,115 @@
+[MASTER]
+persistent=yes
+ignore=vendor,Bouncers,ezt.py
+
+[MESSAGES CONTROL]
+disable=
+    abstract-method,
+    arguments-differ,
+    attribute-defined-outside-init,
+    bad-super-call,
+    consider-using-f-string,
+    consider-using-set-comprehension,
+    consider-using-ternary,
+    cyclic-import,
+    duplicate-code,
+    exec-used,
+    fixme,
+    import-outside-toplevel,
+    inconsistent-return-statements,
+    invalid-name,
+    invalid-str-returned,
+    keyword-arg-before-vararg,
+    missing-class-docstring,
+    missing-function-docstring,
+    missing-module-docstring,
+    no-else-return,
+    no-member,
+    not-an-iterable,
+    protected-access,
+    raise-missing-from,
+    redefined-argument-from-local,
+    redefined-builtin,
+    redefined-outer-name,
+    superfluous-parens,
+    too-many-ancestors,
+    too-many-branches,
+    too-many-instance-attributes,
+    too-many-lines,
+    too-many-locals,
+    too-many-nested-blocks,
+    too-many-return-statements,
+    too-many-statements,
+    undefined-loop-variable,
+    unnecessary-lambda-assignment,
+    unspecified-encoding,
+    unsubscriptable-object,
+    unsupported-assignment-operation,
+    unsupported-membership-test,
+    unused-argument,
+    use-a-generator,
+    use-implicit-booleaness-not-comparison
+
+
+[REPORTS]
+output-format=parseable
+
+
+[BASIC]
+no-docstring-rgx=__.*__|_.*
+class-rgx=[A-Z_][a-zA-Z0-9_]+$
+function-rgx=[a-zA_][a-zA-Z0-9_]{2,70}$
+method-rgx=[a-z_][a-zA-Z0-9_]{2,70}$
+const-rgx=(([A-Z_][A-Z0-9_]*)|([a-z_][a-z0-9_]*)|(__.*__)|register|urlpatterns)$
+good-names=_,i,j,k,e,x,Run,,setUp,tearDown,r,p,s,v,fd
+
+[TYPECHECK]
+
+# Tells whether missing members accessed in mixin class should be ignored. A
+# mixin class is detected if its name ends with "mixin" (case insensitive).
+ignore-mixin-members=yes
+
+# List of classes names for which member attributes should not be checked
+# (useful for classes with attributes dynamically set).
+ignored-classes=SQLObject,WSGIRequest,Publisher,NullSessionManager
+
+# List of members which are set dynamically and missed by pylint inference
+# system, and so shouldn't trigger E0201 when accessed.
+generated-members=objects,DoesNotExist,id,pk,_meta,base_fields,context
+
+# List of method names used to declare (i.e. assign) instance attributes
+defining-attr-methods=__init__,__new__,setUp
+
+
+[VARIABLES]
+init-import=no
+dummy-variables-rgx=_|dummy
+additional-builtins=_,N_,ngettext
+good-names=_,i,j,k,e,x,Run,,setUp,tearDown,r,p,s,v,fd
+
+[SIMILARITIES]
+min-similarity-lines=6
+ignore-comments=yes
+ignore-docstrings=yes
+
+
+[MISCELLANEOUS]
+notes=FIXME,XXX,TODO
+
+
+[FORMAT]
+max-line-length=160
+max-module-lines=2000
+indent-string='    '
+
+
+[DESIGN]
+max-args=10
+max-locals=15
+max-returns=6
+max-branches=12
+max-statements=50
+max-parents=7
+max-attributes=7
+min-public-methods=0
+max-public-methods=50
diff --git a/pylint.sh b/pylint.sh
new file mode 100755
index 0000000..8912e29
--- /dev/null
+++ b/pylint.sh
@@ -0,0 +1,5 @@
+#! /bin/bash
+set -e -x
+env
+
+pylint -f parseable --rcfile pylint.rc "$@" | tee pylint.out || /bin/true
diff --git a/tox.ini b/tox.ini
new file mode 100644
index 0000000..2970091
--- /dev/null
+++ b/tox.ini
@@ -0,0 +1,12 @@
+[tox]
+envlist = codestyle-pylint
+toxworkdir = {env:TMPDIR:/tmp}/tox-{env:USER}/scrutiny/{env:BRANCH_NAME:}
+
+[testenv]
+deps =
+  codestyle: pre-commit
+  pylint: pylint
+  pylint: pylint-django
+commands =
+  codestyle: pre-commit run --all-files --show-diff-on-failure
+  pylint: ./pylint.sh gadjo/