From ff245940ec1988d09d217b27a7d214e593106272 Mon Sep 17 00:00:00 2001 From: Benjamin Dauvergne Date: Tue, 18 Feb 2020 17:10:19 +0100 Subject: [PATCH] payfip_ws: add resultrans codes for direct debit (#39985) --- eopayment/payfip_ws.py | 12 +++++++++--- tests/test_payfip_ws.py | 6 +++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/eopayment/payfip_ws.py b/eopayment/payfip_ws.py index eaeaeb3..2b6e2c1 100644 --- a/eopayment/payfip_ws.py +++ b/eopayment/payfip_ws.py @@ -249,13 +249,19 @@ class Payment(PaymentCommon): if response.resultrans == 'P': result = PAID - bank_status = '' + bank_status = 'paid CB' + elif response.resultrans == 'V': + result = PAID + bank_status = 'paid direct debit' elif response.resultrans == 'R': result = DENIED - bank_status = 'refused' + bank_status = 'refused CB' + elif response.resultrans == 'Z': + result = DENIED + bank_status = 'refused direct debit' elif response.resultrans == 'A': result = CANCELLED - bank_status = 'cancelled' + bank_status = 'cancelled CB' else: result = ERROR bank_status = 'unknown result code: %r' % response.resultrans diff --git a/tests/test_payfip_ws.py b/tests/test_payfip_ws.py index 0076bc6..5580081 100644 --- a/tests/test_payfip_ws.py +++ b/tests/test_payfip_ws.py @@ -195,7 +195,7 @@ def test_payment_ok(request): response = payment.response('idop=%s' % payment_id) assert response.result == eopayment.PAID - assert response.bank_status == '' + assert response.bank_status == 'paid CB' assert response.order_id == payment_id assert response.transaction_id == ( '201912261758460053903194 cc0cb210-1cd4-11ea-8cca-0213ad91a103 112233445566-tip') @@ -221,7 +221,7 @@ def test_payment_denied(request): response = payment.response('idop=%s' % payment_id) assert response.result == eopayment.DENIED - assert response.bank_status == 'refused' + assert response.bank_status == 'refused CB' assert response.order_id == payment_id assert response.transaction_id == '201912261758460053903194 cc0cb210-1cd4-11ea-8cca-0213ad91a103' @@ -246,6 +246,6 @@ def test_payment_cancelled(request): response = payment.response('idop=%s' % payment_id) assert response.result == eopayment.CANCELLED - assert response.bank_status == 'cancelled' + assert response.bank_status == 'cancelled CB' assert response.order_id == payment_id assert response.transaction_id == '201912261758460053903194 cc0cb210-1cd4-11ea-8cca-0213ad91a103'