From 50cb52b160d6a21654367e0c28ab491d95609386 Mon Sep 17 00:00:00 2001 From: Valentin Deniaud Date: Tue, 23 Nov 2021 14:41:01 +0100 Subject: [PATCH] views: render debug login template at the last moment (#58906) --- mellon/views.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mellon/views.py b/mellon/views.py index 8920e22..316a6c8 100644 --- a/mellon/views.py +++ b/mellon/views.py @@ -289,6 +289,8 @@ class LoginView(ProfileMixin, LogMixin, View): self.log.debug('trying to authenticate with attributes %r', attributes) response = self.authenticate(request, login, attributes) response.delete_cookie(RETRY_LOGIN_COOKIE) + if self.debug_login: + return self.render_debug_template(request, login, attributes) return response def authenticate(self, request, login, attributes): @@ -311,10 +313,7 @@ class LoginView(ProfileMixin, LogMixin, View): return self.render(request, 'mellon/user_not_found.html', {'saml_attributes': attributes}) request.session['lasso_session_dump'] = login.session.dump() - if self.debug_login: - return self.render_debug_template(request, login, attributes) - else: - return HttpResponseRedirect(next_url) + return HttpResponseRedirect(next_url) def render_debug_template(self, request, login, attributes): request.session['mellon_debug_login'] = False