From 5ed0b40379cd7f2224c9f6616616460bf93ff888 Mon Sep 17 00:00:00 2001 From: Benjamin Dauvergne Date: Thu, 13 Jan 2022 00:05:11 +0100 Subject: [PATCH] views: fix undefined user variable If negoration needs more than one round-trip, the user variable is undefined. --- src/django_gssapi/views.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/django_gssapi/views.py b/src/django_gssapi/views.py index f19741c..e832f97 100644 --- a/src/django_gssapi/views.py +++ b/src/django_gssapi/views.py @@ -82,12 +82,13 @@ class LoginView(View): store=self.get_gssapi_store()) except utils.NegotiateContinue as e: token = e.token + user = None - if user is None: - response = self.challenge() - else: + if user is not None: logger.debug('GSSAPI found user %s for name %s', user, gss_name) response = self.success(user) + else: + response = self.challenge() utils.response_add_www_authenticate(response, token) return response