From 23bc0434a2b21b60c3dd464ebcdf729f4a89928a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jurko=20Gospodneti=C4=87?= Date: Wed, 1 Jul 2015 11:14:52 +0200 Subject: [PATCH] add todo comment on cleaning up XSD Schema build step timing --- suds/xsd/schema.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/suds/xsd/schema.py b/suds/xsd/schema.py index 7dab3ab..0945d27 100644 --- a/suds/xsd/schema.py +++ b/suds/xsd/schema.py @@ -237,6 +237,17 @@ class Schema(UnicodeMixin): # really necessary or if we can simply build our top-level WSDL # contained schemata one by one as they are loaded if container is None: + #TODO: It seems like this build() step can be done for each schema + # on its own instead of letting the container do it. Building our + # XSD schema objects should not require any external schema + # information and even references between XSD schema objects within + # the same schema can not be established until all the XSD schema + # objects have been built. The only reason I can see right now why + # this step has been placed under container control is so our + # container (a SchemaCollection instance) can add some additional + # XML elements to our schema before our XSD schema object entities + # get built, but there is bound to be a cleaner way to do this, + # similar to how we support such XML modifications in suds plugins. self.build() self.open_imports(options) log.debug("built:\n%s", self)