From 110344408c38c3d642191f46a97b7cba0d7aefc9 Mon Sep 17 00:00:00 2001 From: David Cramer Date: Tue, 23 Feb 2016 16:15:11 -0800 Subject: [PATCH] Dont implicitly configure log handlers Because of the way logging propagation works this is complicated to ensure it's intelligent. Let's leave it up to the user to ensure LOGGING is configured appropriately for their application. --- CHANGES | 6 ++++++ raven/base.py | 10 ---------- setup.py | 2 +- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/CHANGES b/CHANGES index ff40088a..dc995a75 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,9 @@ +Version 5.11.0 +-------------- + +* ``Client.configure_logging`` has been removed, and handlers will not automatically + be added to 'sentry' and 'raven' namespaces. + Version 5.10.3 -------------- diff --git a/raven/base.py b/raven/base.py index 1cbee896..6cceca81 100644 --- a/raven/base.py +++ b/raven/base.py @@ -133,8 +133,6 @@ class Client(object): o = options - self.configure_logging() - self.raise_send_errors = raise_send_errors # configure loggers first @@ -225,14 +223,6 @@ class Client(object): def register_scheme(cls, scheme, transport_class): cls._registry.register_scheme(scheme, transport_class) - def configure_logging(self): - for name in ('raven', 'sentry'): - logger = logging.getLogger(name) - if logger.handlers: - continue - logger.addHandler(logging.StreamHandler()) - logger.setLevel(logging.INFO) - def get_processors(self): for processor in self.processors: yield self.module_cache[processor](self) diff --git a/setup.py b/setup.py index 60719ff1..4df9a04c 100755 --- a/setup.py +++ b/setup.py @@ -97,7 +97,7 @@ class PyTest(TestCommand): setup( name='raven', - version='5.10.3.dev.0', + version='5.11.0.dev.0', author='Sentry', author_email='hello@getsentry.com', url='https://github.com/getsentry/raven-python',