entrouvert
/
combo
16
1
Fork 0
Code Issues Pull Requests 10 Releases Wiki Activity

dataviz: use select2 widget for all filters (#71885) #83

Open
vdeniaud wants to merge 3 commits from wip/71885-select2-dataviz into main
pull from: wip/71885-select2-dataviz
merge into: entrouvert:main
Conversation 1 Commits 3 Files Changed 6 +354 -94
vdeniaud commented 2023-04-20 16:00:31 +02:00
Owner
Copy Link
No description provided.
vdeniaud changed title from dataviz: use select2 widget for all filters (#71885) to WIP: dataviz: use select2 widget for all filters (#71885) 2023-04-20 16:00:36 +02:00
vdeniaud force-pushed wip/71885-select2-dataviz from acf6c3c945 to 1331c8aa30 2023-04-20 17:09:15 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from 1331c8aa30 to 16bd99559c 2023-04-26 14:44:38 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from 16bd99559c to 60a6ec23c1 2023-04-26 15:10:55 +02:00 Compare
vdeniaud changed title from WIP: dataviz: use select2 widget for all filters (#71885) to dataviz: use select2 widget for all filters (#71885) 2023-04-26 15:34:57 +02:00
vdeniaud force-pushed wip/71885-select2-dataviz from 60a6ec23c1 to 95cf3ef1b9 2023-05-09 11:18:37 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from 95cf3ef1b9 to c3ce09bb1c 2023-05-17 14:57:08 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from c3ce09bb1c to f61e84fc37 2023-05-17 15:40:14 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from f61e84fc37 to 3ca889df32 2023-05-17 16:19:34 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from 3ca889df32 to 10822f0377 2023-05-30 15:11:06 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from 10822f0377 to 73d3bf62b9 2023-06-01 10:51:44 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from 73d3bf62b9 to f388da50c9 2023-06-12 12:02:25 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from f388da50c9 to 3dac5ccdaa 2023-06-27 13:35:06 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from 3dac5ccdaa to 4c2618cce3 2023-07-04 11:01:53 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from 4c2618cce3 to 17171bb325 2023-08-02 15:36:09 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from 17171bb325 to 162f790fc4 2023-08-17 18:01:24 +02:00 Compare
vdeniaud force-pushed wip/71885-select2-dataviz from 162f790fc4 to 072015e8b4 2023-08-17 18:08:28 +02:00 Compare
vdeniaud commented 2023-08-17 18:09:03 +02:00
Author
Owner
Copy Link

Pas de relecture en 4 mois donc c'est qu'il y avait un problème avec les patches, j'ai repris.

Je pense que j'avais surtout pêché à vouloir avoir des widgets trop génériques, à la place je ne cherche plus à mutualiser le select2 de dataviz avec le select2 des autres endroits combo (sélection des rôles, filtres de la cellule fiche, etc). Le code est un peu moins concis mais sûrement plus facilement navigable et maintenable.

Ça donne :
0001 : simplification nécessaire de la construction des choix des filtres, le code gagne pas mal en lisibilité au passage.
0002 : un gros patch qui ajoute widgets et vues.
0003 : compliqué d'avoir les choix de la cellule filtre en ajax, donc désactivation dans ce cas.

Pas de relecture en 4 mois donc c'est qu'il y avait un problème avec les patches, j'ai repris. Je pense que j'avais surtout pêché à vouloir avoir des widgets trop génériques, à la place je ne cherche plus à mutualiser le select2 de dataviz avec le select2 des autres endroits combo (sélection des rôles, filtres de la cellule fiche, etc). Le code est un peu moins concis mais sûrement plus facilement navigable et maintenable. Ça donne : 0001 : simplification nécessaire de la construction des choix des filtres, le code gagne pas mal en lisibilité au passage. 0002 : un gros patch qui ajoute widgets et vues. 0003 : compliqué d'avoir les choix de la cellule filtre en ajax, donc désactivation dans ce cas.
vdeniaud force-pushed wip/71885-select2-dataviz from 072015e8b4 to e5d3357951 2023-08-17 18:10:31 +02:00 Compare
vdeniaud changed title from dataviz: use select2 widget for all filters (#71885) to WIP: dataviz: use select2 widget for all filters (#71885) 2023-08-17 18:11:04 +02:00
vdeniaud changed title from WIP: dataviz: use select2 widget for all filters (#71885) to dataviz: use select2 widget for all filters (#71885) 2023-08-17 18:15:37 +02:00
fpeters approved these changes 2023-11-14 10:26:34 +01:00
vdeniaud force-pushed wip/71885-select2-dataviz from e5d3357951 to ff1e2f9bab 2024-04-18 17:18:27 +02:00 Compare
All checks were successful
gitea/combo/pipeline/head This commit looks good
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
fpeters
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/combo#83
No description provided.
Delete Branch "wip/71885-select2-dataviz"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?