diff --git a/combo/apps/newsletters/models.py b/combo/apps/newsletters/models.py index ab26d5fd..153c4b09 100644 --- a/combo/apps/newsletters/models.py +++ b/combo/apps/newsletters/models.py @@ -123,8 +123,8 @@ class NewslettersCell(CellBase): endpoint = self.url + 'newsletters/' url = get_signed_url(endpoint, self.url, **kwargs) response = requests.get(url) - json_response = response.json() - if json_response['err'] == 0: + if response.ok: + json_response = response.json() return self.filter_data(json_response['data']) return [] @@ -132,8 +132,8 @@ class NewslettersCell(CellBase): endpoint = self.url + 'subscriptions/' url = get_signed_url(endpoint, self.url, **kwargs) response = requests.get(url) - json_response = response.json() - if json_response['err'] == 0: + if response.ok: + json_response = response.json() return self.filter_data(json_response['data']) return [] diff --git a/tests/test_newsletters_cell.py b/tests/test_newsletters_cell.py index aba122b1..d5e74bc7 100644 --- a/tests/test_newsletters_cell.py +++ b/tests/test_newsletters_cell.py @@ -158,13 +158,17 @@ def mocked_requests_get(*args, **kwargs): class MockResponse: def __init__(self, json_data): self.json_data = json_data + + def ok(self): + return True + def json(self): return self.json_data if 'newsletters' in url: - return MockResponse({'err': 0, 'data': NEWSLETTERS}) + return MockResponse({'data': NEWSLETTERS}) else: - return MockResponse({'err': 0, 'data': SUBSCRIPTIONS}) + return MockResponse({'data': SUBSCRIPTIONS}) @mock.patch('combo.apps.newsletters.models.requests.get', side_effect=mocked_requests_get)