From 4656b505746a0e2ed4e44a94360058da2e52e43d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= <fpeters@entrouvert.com>
Date: Fri, 1 Nov 2019 12:59:42 +0100
Subject: [PATCH] manager: add uppercases to page actions (#37398)

---
 combo/manager/templates/combo/page_view.html | 10 +++++-----
 tests/test_manager.py                        | 14 +++++++-------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/combo/manager/templates/combo/page_view.html b/combo/manager/templates/combo/page_view.html
index fc8dbec2..5ae1dbcc 100644
--- a/combo/manager/templates/combo/page_view.html
+++ b/combo/manager/templates/combo/page_view.html
@@ -7,13 +7,13 @@
 <h2>{% trans 'Page' %} - {{ object.title }}</h2>
 <span class="actions">
 <a class="extra-actions-menu-opener"></a>
-<a href="{{ object.get_online_url }}">{% trans 'see online' %}</a>
+<a href="{{ object.get_online_url }}">{% trans 'See online' %}</a>
 <ul class="extra-actions-menu">
-  <li><a href="{% url 'combo-manager-page-history' pk=object.id %}">{% trans 'history' %}</a></li>
-  <li><a download href="{% url 'combo-manager-page-export' pk=object.id %}">{% trans 'export' %}</a></li>
-  <li><a rel="popup" href="{% url 'combo-manager-page-add-child' pk=object.id %}">{% trans 'add a child page' %}</a></li>
+  <li><a href="{% url 'combo-manager-page-history' pk=object.id %}">{% trans 'History' %}</a></li>
+  <li><a download href="{% url 'combo-manager-page-export' pk=object.id %}">{% trans 'Export' %}</a></li>
+  <li><a rel="popup" href="{% url 'combo-manager-page-add-child' pk=object.id %}">{% trans 'Add a child page' %}</a></li>
   <li><a href="{% url 'combo-manager-page-duplicate' pk=object.id %}">{% trans 'Duplicate' %}</a></li>
-  <li><a rel="popup" href="{% url 'combo-manager-page-delete' pk=object.id %}">{% trans 'delete' %}</a></li>
+  <li><a rel="popup" href="{% url 'combo-manager-page-delete' pk=object.id %}">{% trans 'Delete' %}</a></li>
 </ul>
 </span>
 {% endblock %}
diff --git a/tests/test_manager.py b/tests/test_manager.py
index 1860de32..4c990127 100644
--- a/tests/test_manager.py
+++ b/tests/test_manager.py
@@ -256,7 +256,7 @@ def test_delete_page(app, admin_user):
     page.save()
     app = login(app)
     resp = app.get('/manage/pages/%s/' % page.id)
-    resp = resp.click('delete')
+    resp = resp.click('Delete')
     assert '<button class="delete-button">Delete</button>' in resp.text
     resp = resp.forms[0].submit()
     assert resp.location.endswith('/manage/')
@@ -270,7 +270,7 @@ def test_delete_page_keep_child(app, admin_user):
     page2.save()
     app = login(app)
     resp = app.get('/manage/pages/%s/' % page.id)
-    resp = resp.click('delete')
+    resp = resp.click('Delete')
     assert '<button class="delete-button">Delete</button>' in resp.text
     assert 'Delete only this page' in resp.text
     assert 'Delete this page and all subpages' in resp.text
@@ -289,7 +289,7 @@ def test_delete_page_and_subpage(app, admin_user):
     page2.save()
     app = login(app)
     resp = app.get('/manage/pages/%s/' % page.id)
-    resp = resp.click('delete')
+    resp = resp.click('Delete')
     assert '<button class="delete-button">Delete</button>' in resp.text
     assert 'Delete only this page' in resp.text
     assert 'Delete this page and all subpages' in resp.text
@@ -378,7 +378,7 @@ def test_export_page(app, admin_user):
     page.save()
     app = login(app)
     resp = app.get('/manage/pages/%s/' % page.id)
-    resp = resp.click('export')
+    resp = resp.click('Export')
     assert resp.headers['content-type'] == 'application/json'
     assert resp.json['pages'][0].get('fields').get('slug') == 'one'
 
@@ -1244,7 +1244,7 @@ def test_page_versionning(app, admin_user):
     app.get('/manage/pages/%s/order?%s' % (page.id, urlencode(params)))
     assert PageSnapshot.objects.all().count() == 3
 
-    resp = resp.click('history')
+    resp = resp.click('History')
     assert resp.text.index('reordered cells') < resp.text.index('changed cell') < resp.text.index('changed title')
 
     resp2 = resp.click('view', index=1)
@@ -1275,7 +1275,7 @@ def test_page_versionning(app, admin_user):
     resp.forms[1]['c%s-text' % cell1.get_reference()].value = 'Foo back to 1'
     resp = resp.forms[0].submit().follow()
 
-    resp = resp.click('history')
+    resp = resp.click('History')
     assert 'added cell' in resp.text
 
     resp2 = resp.click('view', index=1)
@@ -1307,7 +1307,7 @@ def test_page_versionning(app, admin_user):
     resp = resp.form.submit()
     resp = resp.follow()
 
-    resp2 = resp.click('see online')
+    resp2 = resp.click('See online')
     assert resp2.text.index('Foobar1') < resp2.text.index('Foobar2') < resp2.text.index('Foobar3')
 
     # clean it up