From 8ac172704568589b1d6de185cf854effc79cc300 Mon Sep 17 00:00:00 2001 From: Thomas NOEL Date: Thu, 13 Jul 2017 14:00:36 +0200 Subject: [PATCH] saga_transaction: test URL presence after all others errors --- combo_plugin_nanterre/views.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/combo_plugin_nanterre/views.py b/combo_plugin_nanterre/views.py index a79a1c5..c7f0dfa 100644 --- a/combo_plugin_nanterre/views.py +++ b/combo_plugin_nanterre/views.py @@ -72,7 +72,7 @@ def saga_transaction(request): 'for num_factures=%s', num_factures) messages.error(request, ERROR_MESSAGE) return HttpResponseRedirect(error_url) - if not isinstance(saga, dict) or not saga.get('data', {}).get('url'): + if not isinstance(saga, dict): logger.error('[rsu/saga] failed to create transaction ' 'for num_factures=%s, received bad response=%r', num_factures, saga) @@ -91,6 +91,12 @@ def saga_transaction(request): num_factures, saga['err']) messages.error(request, ERROR_MESSAGE) return HttpResponseRedirect(error_url) + if not saga.get('data', {}).get('url'): + logger.error('[rsu/saga] failed to create transaction ' + 'for num_factures=%s, response without url: %r', + num_factures, saga) + messages.error(request, ERROR_MESSAGE) + return HttpResponseRedirect(error_url) # finally, response seems good! redirect to payment system URL logger.info('[rsu/saga] new transaction created '