api: hide check fields for bookings of meetings agendas (#69169) #3

Merged
aberriot merged 1 commits from wip/69169-api-check-fields-for-meetings into main 2022-11-07 14:49:20 +01:00
Owner
  • Thème mobile
  • correction d'un bug d'affichage sous IE 11
  • Prévenir le client
- [x] Thème mobile - [x] correction d'un bug d'affichage sous IE 11 - [x] Prévenir le client
aberriot added 1 commit 2022-11-07 14:35:29 +01:00
gitea-wip/chrono/pipeline/pr-main This commit looks good Details
8d07b36d38
api: hide check fields for bookings of meetings agendas (#69169)
Ghost requested review from pmarillonnet 2022-11-07 14:38:06 +01:00
aberriot changed title from api: hide check fields for bookings of meetings agendas (#69169) to WIP: api: hide check fields for bookings of meetings agendas (#69169) 2022-11-07 14:38:48 +01:00
aberriot changed title from WIP: api: hide check fields for bookings of meetings agendas (#69169) to api: hide check fields for bookings of meetings agendas (#69169) 2022-11-07 14:39:48 +01:00
aberriot reviewed 2022-11-07 14:44:33 +01:00
aberriot left a comment
Author
Owner

Tout est bon pour moi a part les deux remarques.

Tout est bon pour moi a part les deux remarques.
@ -237,1 +232,3 @@
)
if self.instance.event.agenda.kind != 'events':
ret.pop('user_was_present', None)
ret.pop('user_absence_reason', None)
Author
Owner

Pourquoi on a besoin de ça ici ?

Pourquoi on a besoin de ça ici ?
Author
Owner

@aberriot c'est pour une raison X.

@aberriot c'est pour une raison X.
aberriot marked this conversation as resolved
@ -2540,0 +2543,4 @@
or 'user_absence_reason' in request.data
or 'user_presence_reason' in request.data
):
raise APIErrorBadRequest(N_('can not set check fields for non events agenda'), err=7)
Author
Owner

Je crois qu'il y a une typo.

Je crois qu'il y a une typo.
Owner

Un petit test

Un petit test
aberriot marked this conversation as resolved
aberriot removed review request for pmarillonnet 2022-11-07 14:46:29 +01:00
pmarillonnet approved these changes 2022-11-07 14:47:14 +01:00
pmarillonnet left a comment
Owner

Ok pour moi.

Ok pour moi.
aberriot merged commit 8d07b36d38 into main 2022-11-07 14:49:20 +01:00
aberriot deleted branch wip/69169-api-check-fields-for-meetings 2022-11-07 14:49:20 +01:00
Owner

(relu pour de vrai, je revalide à posteriori)

(relu pour de vrai, je revalide à posteriori)
vdeniaud requested review from vdeniaud 2022-11-07 17:41:08 +01:00
vdeniaud approved these changes 2022-11-07 17:43:11 +01:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/chrono#3
No description provided.