From 2a2112ceac920583ac2a5437ac07077c7680ecbb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Laur=C3=A9line=20Gu=C3=A9rin?= Date: Thu, 22 Sep 2022 19:21:08 +0200 Subject: [PATCH] manager: fix custom field form (#69467) --- chrono/manager/forms.py | 2 +- tests/manager/test_events_type.py | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/chrono/manager/forms.py b/chrono/manager/forms.py index 62d1c957..dfb79a87 100644 --- a/chrono/manager/forms.py +++ b/chrono/manager/forms.py @@ -399,7 +399,7 @@ class CustomFieldForm(forms.Form): if cleaned_data.get('varname') and not cleaned_data.get('label'): self.add_error('label', _('This field is required.')) if cleaned_data.get('varname') and not cleaned_data.get('field_type'): - self.add_error('field', _('This field is required.')) + self.add_error('field_type', _('This field is required.')) return cleaned_data diff --git a/tests/manager/test_events_type.py b/tests/manager/test_events_type.py index 0810a6d1..4c0f46bf 100644 --- a/tests/manager/test_events_type.py +++ b/tests/manager/test_events_type.py @@ -67,8 +67,14 @@ def test_edit_events_type_custom_fields(app, admin_user): resp = app.get('/manage/events-type/%s/edit/' % events_type.pk) resp.form['form-0-varname'] = 'foo' resp.form['form-0-label'] = 'Foo' + resp = resp.form.submit() + assert resp.context['formset'][0].errors['field_type'] == ['This field is required.'] + resp.form['form-0-label'] = '' resp.form['form-0-field_type'] = 'text' resp = resp.form.submit() + assert resp.context['formset'][0].errors['label'] == ['This field is required.'] + resp.form['form-0-label'] = 'Foo' + resp = resp.form.submit() assert resp.status_code == 302 events_type.refresh_from_db() assert events_type.custom_fields == [