From af72ac81833aa2acabe11bba7aca6a05848ed082 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= Date: Thu, 16 Jul 2020 19:01:17 +0200 Subject: [PATCH] misc: never alter form fields dictionary during iteration (#45201) --- src/authentic2_cut/apps.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/authentic2_cut/apps.py b/src/authentic2_cut/apps.py index 22ac619..795ca7c 100644 --- a/src/authentic2_cut/apps.py +++ b/src/authentic2_cut/apps.py @@ -116,7 +116,7 @@ class AppConfig(django.apps.AppConfig): del form.fields['creation_domain'] del form.fields['validation_partner'] else: - for field_name in form.fields: + for field_name in list(form.fields): if field_name not in ['username', 'first_name', 'last_name', @@ -144,7 +144,7 @@ class AppConfig(django.apps.AppConfig): del form.fields[field_name] form.fields['comment'].widget = Textarea(attrs={'rows': 4}) else: - for field_name in form.fields: + for field_name in list(form.fields): if field_name not in ['username', 'first_name', 'last_name', @@ -167,7 +167,7 @@ class AppConfig(django.apps.AppConfig): # Si un compte est validé, on interdit la modification des attributs coeurs if form.instance.attributes.validated: - for field_name in form.fields: + for field_name in list(form.fields): if field_name in ['first_name', 'last_name', 'birthcountry_insee', @@ -208,7 +208,7 @@ class AppConfig(django.apps.AppConfig): del form.fields[field_name] form.fields['comment'].widget = Textarea(attrs={'readonly': '', 'rows': 4}) else: - for field_name in form.fields: + for field_name in list(form.fields): if field_name not in ['username', 'first_name', 'last_name', 'email']: del form.fields[field_name]