From 97a5ebf63a64f98843315bedf6820ca1f34ffb24 Mon Sep 17 00:00:00 2001 From: Paul Marillonnet Date: Wed, 30 Nov 2022 16:49:39 +0100 Subject: [PATCH] =?UTF-8?q?Revert=20"idp=5Foidc:=20add=20api=20access=20an?= =?UTF-8?q?d=20profile=20[=E2=80=A6]=20(#71820)"=20(#71890)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 9141583b582d98f1b59003fe0b0e8b33246d38b2. The (erroneously added) parameters are for Publik's out-of-spec synchronization purposes, they shouldn't appear on the vanilla OIDC client configuration interface. --- src/authentic2_idp_oidc/manager/forms.py | 2 -- tests/idp_oidc/test_manager.py | 4 ---- 2 files changed, 6 deletions(-) diff --git a/src/authentic2_idp_oidc/manager/forms.py b/src/authentic2_idp_oidc/manager/forms.py index 86a668bfb..5d457acc1 100644 --- a/src/authentic2_idp_oidc/manager/forms.py +++ b/src/authentic2_idp_oidc/manager/forms.py @@ -38,8 +38,6 @@ class OIDCClientForm(SlugMixin, forms.ModelForm): 'authorization_mode', 'authorization_flow', 'home_url', - 'has_api_access', - 'activate_user_profiles', 'colour', 'logo', ] diff --git a/tests/idp_oidc/test_manager.py b/tests/idp_oidc/test_manager.py index 6105ad8a0..44d6a9dbf 100644 --- a/tests/idp_oidc/test_manager.py +++ b/tests/idp_oidc/test_manager.py @@ -37,15 +37,11 @@ def test_add_oidc_service(app): form = resp.form form['name'] = 'Test' form['redirect_uris'] = 'http://example.com' - form['has_api_access'] = True - form['activate_user_profiles'] = True resp = form.submit() assert OIDCClient.objects.count() == 1 assert OIDCClaim.objects.count() == len(oidc_app_settings.DEFAULT_MAPPINGS) oidc_client = OIDCClient.objects.get() - assert oidc_client.has_api_access is True - assert oidc_client.activate_user_profiles is True assert resp.location == f'/manage/services/{oidc_client.pk}/' resp = resp.follow() assert "Settings" in resp.text