From 95701c5e762dc60396869d6159ea31f6e3192281 Mon Sep 17 00:00:00 2001
From: Yann Weber <yweber@entrouvert.org>
Date: Thu, 14 Mar 2024 14:23:13 +0100
Subject: [PATCH] manager: add display condition on homepage sidebar title
 (#87961)

---
 .../templates/authentic2/manager/homepage.html        |  4 +++-
 tests/test_manager.py                                 | 11 +++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/authentic2/manager/templates/authentic2/manager/homepage.html b/src/authentic2/manager/templates/authentic2/manager/homepage.html
index 44d41cdba..5e06e7d9f 100644
--- a/src/authentic2/manager/templates/authentic2/manager/homepage.html
+++ b/src/authentic2/manager/templates/authentic2/manager/homepage.html
@@ -32,7 +32,9 @@
 
 {% block sidebar %}
   <aside id="sidebar">
-    <h3>{% blocktrans %}Configuration & technical information{% endblocktrans %}</h3>
+    {% if sidebar_entries %}
+      <h3>{% blocktrans %}Configuration & technical information{% endblocktrans %}</h3>
+    {% endif %}
     <div class="a2-manager-id-tools_content">
       {% for entry in sidebar_entries %}
         <a id="{{ entry.slug }}" class="button button-paragraph" href="{{ entry.href }}">{{ entry.label }}</a>
diff --git a/tests/test_manager.py b/tests/test_manager.py
index 78c9f9f13..a004ab84a 100644
--- a/tests/test_manager.py
+++ b/tests/test_manager.py
@@ -926,6 +926,17 @@ def test_manager_homepage_import_export_hidden(admin, app):
     assert 'site-export' not in manager_home_page.text
 
 
+def test_manager_homepage_sidebar_title(app, simple_user, admin):
+    user_admin_role = Role.objects.get(slug='_a2-manager-of-users')
+    simple_user.roles.add(user_admin_role)
+    manager_homepage = login(app, simple_user, reverse('a2-manager-homepage'))
+    assert 'Configuration & technical information' not in manager_homepage
+    logout(app)
+
+    manager_homepage = login(app, admin, reverse('a2-manager-homepage'))
+    assert 'Configuration & technical information' in manager_homepage
+
+
 def test_manager_ou(app, superuser_or_admin, ou1):
     manager_home_page = login(app, superuser_or_admin, reverse('a2-manager-homepage'))
     ou_homepage = manager_home_page.click(href='organizational-units')