fix Typer.genprefix() code broken in recent code cleanup

Unfortunately not covered by the existing test suite, and only added a TODO note
to add the missing tests.
This commit is contained in:
Jurko Gospodnetić 2015-07-14 10:04:41 +02:00
parent 29f6b5917f
commit f0ba96e23e
2 changed files with 19 additions and 4 deletions

View File

@ -1503,13 +1503,22 @@ PRIORITIZED:
(+) * (Jurko) Review and commit unpublished cleanup work on Jurko's machine.
(01.06.2015.)
(01.07.2015.)
(+) * (Jurko) Fix recursive XSD import issue.
(+) * Add tests.
(+) * Fix issue.
(02.06.2015.)
(14.07.2015.)
(+) * (Jurko) Fix issue https://bitbucket.org/jurko/suds/issues/90 - code in
(+) `mx/typer.py` Typer.genprefix() broken by commit
(+) 103efca86cd07e9d7205ffb2735748f275a4b35f.
(+) * Add todo note to improve test coverage that managed to miss this
(+) problem.
(+) * Fix.
(15.07.2015.)
* (Jurko) Review and commit unpublished cleanup work on Jurko's machine.
@ -1922,10 +1931,16 @@ PRIORITIZED:
* (Jurko) Look into issues #7 & #13 on BitBucket - problems loading a WSDL
containing a recursively defined XML schema.
* Possibly already fixed by related work done around 01.07.2015.
NON PRIORITIZED:
=================================================
* Add tests for Typer.genprefix().
* Got broken in commit 103efca86cd07e9d7205ffb2735748f275a4b35f and
fixed as part of issue https://bitbucket.org/jurko/suds/issues/90 but
the bug was missed by the existing test suite.
* suds.sudsobject.footprint() does some fancy recursive counting while all
it is actually used for is for detecting objects with footprint 0. This
could be optimized by replacing it with a function returning simply

View File

@ -109,8 +109,8 @@ class Typer:
@rtype: (prefix, URI)
"""
for node in range(1, 1024):
prefix = "ns%d" % (node,)
for i in range(1, 1024):
prefix = "ns%d" % (i,)
uri = node.resolvePrefix(prefix, default=None)
if uri in (None, ns[1]):
return prefix, ns[1]