refactor: do not use mutable arguments

This commit is contained in:
Bojan Mihelac 2018-12-03 16:06:26 +01:00
parent cd28fd0fe4
commit 596a4f5b54
1 changed files with 5 additions and 2 deletions

View File

@ -272,7 +272,7 @@ class Resource(six.with_metaclass(DeclarativeMetaclass)):
else:
return (self.init_instance(row), True)
def validate_instance(self, instance, import_validation_errors={}, validate_unique=True):
def validate_instance(self, instance, import_validation_errors=None, validate_unique=True):
"""
Takes any validation errors that were raised by
:meth:`~import_export.resources.Resource.import_obj`, and combines them
@ -284,7 +284,10 @@ class Resource(six.with_metaclass(DeclarativeMetaclass)):
``full_clean()`` method is not called, and only the errors raised by
``import_obj()`` are re-raised.
"""
errors = import_validation_errors.copy()
if import_validation_errors is None:
errors = {}
else:
errors = import_validation_errors.copy()
if self._meta.clean_model_instances:
try:
instance.full_clean(