misc: never alter form fields dictionary during iteration (#45201)

This commit is contained in:
Frédéric Péters 2020-07-16 19:01:17 +02:00
parent d78ce337ec
commit af72ac8183
1 changed files with 4 additions and 4 deletions

View File

@ -116,7 +116,7 @@ class AppConfig(django.apps.AppConfig):
del form.fields['creation_domain']
del form.fields['validation_partner']
else:
for field_name in form.fields:
for field_name in list(form.fields):
if field_name not in ['username',
'first_name',
'last_name',
@ -144,7 +144,7 @@ class AppConfig(django.apps.AppConfig):
del form.fields[field_name]
form.fields['comment'].widget = Textarea(attrs={'rows': 4})
else:
for field_name in form.fields:
for field_name in list(form.fields):
if field_name not in ['username',
'first_name',
'last_name',
@ -167,7 +167,7 @@ class AppConfig(django.apps.AppConfig):
# Si un compte est validé, on interdit la modification des attributs coeurs
if form.instance.attributes.validated:
for field_name in form.fields:
for field_name in list(form.fields):
if field_name in ['first_name',
'last_name',
'birthcountry_insee',
@ -208,7 +208,7 @@ class AppConfig(django.apps.AppConfig):
del form.fields[field_name]
form.fields['comment'].widget = Textarea(attrs={'readonly': '', 'rows': 4})
else:
for field_name in form.fields:
for field_name in list(form.fields):
if field_name not in ['username', 'first_name', 'last_name', 'email']:
del form.fields[field_name]